Minor improvements #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I assume the compiler optimizes this anyways, but it's nicer to look at this way anyways. Signed-off-by: Jens Reidel <adrian@travitia.xyz>
Signed-off-by: Jens Reidel <adrian@travitia.xyz>
Signed-off-by: Jens Reidel <adrian@travitia.xyz>
We would have used the slower UTF-8 validation method if we received more data than necessary for completing the partial codepoint. Signed-off-by: Jens Reidel <adrian@travitia.xyz>
Signed-off-by: Jens Reidel <adrian@travitia.xyz>
Erk-
reviewed
Sep 10, 2024
| @@ -57,7 +60,7 @@ impl WebSocketProtocol { | |||
| macro_rules! ensure_buffer_has_space { | |||
| ($buf:expr, $space:expr) => { | |||
| if $buf.len() < $space { | |||
There was a problem hiding this comment.
Should this not be $buf.capacity()?
There was a problem hiding this comment.
No, this is purely about the data that is currently available to ensure that we can index further in the payload.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing the code yet again to explore benchmark behavior I stumbled across a few things we should polish.