Skip to content

Commit

Permalink
refresh breakpoints as a deferred action + log process priority
Browse files Browse the repository at this point in the history
  • Loading branch information
Eric Winger authored and Eric Winger committed Mar 3, 2023
1 parent c87842e commit 216321e
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
4 changes: 2 additions & 2 deletions sources/JadeiteDebugger.cls
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ reformatSource

refreshBreakPointsIn: methodSourcePresenter
| breakPointSymbol indicators |
BrowserUpdate current logComment: 'about to JadeiteDebugger>>refreshBreakPointsIn:'.
[BrowserUpdate current logComment: 'about to JadeiteDebugger>>refreshBreakPointsIn:'.
BrowserUpdate current
logComment: 'JadeiteDebugger>>refreshBreakPointsIn: `methodSourcePresenter view isOpen`'
, methodSourcePresenter view isOpen printString.
Expand Down Expand Up @@ -548,7 +548,7 @@ refreshBreakPointsIn: methodSourcePresenter
BrowserUpdate current
logComment: 'Got a GPFault while refreshing breakpoints. Terminating active process which should release mutex in the unwind block.'.
Processor activeProcess terminate].
BrowserUpdate current logComment: 'finished JadeiteDebugger>>refreshBreakPointsIn:'!
BrowserUpdate current logComment: 'finished JadeiteDebugger>>refreshBreakPointsIn:'] postToInputQueue!

registerPresentersForUpdates
"copied from RowanProjectsBrowserPresenter>>registerPresentersForUpdates"
Expand Down
8 changes: 5 additions & 3 deletions sources/Rowan UI Base.pax
Original file line number Diff line number Diff line change
Expand Up @@ -3685,8 +3685,9 @@ auditProjectFor: projectName

basicRefreshBreakpointsIn: methodSourcePresenter selection: selection
| breakPointSymbol indicators includesBreakPoint individualBreakPointSymbol |
methodSourcePresenter view isOpen ifFalse:[^self].
methodSourcePresenter view clearContainerIndicators.
methodSourcePresenter view isOpen ifFalse: [^self].

[methodSourcePresenter view clearContainerIndicators.
indicators := OrderedCollection new.
breakPointSymbol := BrowserUpdate current breakpointsEnabled
ifTrue: [#breakPoint]
Expand All @@ -3710,7 +3711,8 @@ basicRefreshBreakpointsIn: methodSourcePresenter selection: selection
range: range
tag: string)].
methodSourcePresenter view indicators: indicators.
[methodSourcePresenter view update] on: GPFault do:[:ex | ex resume]. !
[methodSourcePresenter view update] on: GPFault do: [:ex | ex resume]]
postToInputQueue!

canCommit: projectListPresenter
| projectService |
Expand Down
2 changes: 2 additions & 0 deletions sources/RowanLoggingService.cls
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,8 @@ logServiceDateTimeStampProcessOn: ws
nextPutAll: time printString;
space;
nextPutAll: 'Process: {' , Processor activeProcess identityHash printString , '}';
space;
nextPutAll: 'priority: ', Processor activePriority printString;
space.
mode
ifNotNil:
Expand Down

0 comments on commit 216321e

Please sign in to comment.