Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client update updater bugs #81

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Conversation

yangxuilyx
Copy link

  1. fix _configInfo.UpdateVersions get mainResp
  2. add skipDirectories to avoid locking certain folders, such as cache directories

@JusterZhu
Copy link
Collaborator

(1) I didn't understand why the first fix was needed; the main app needs to be upgraded by the upgrade app.
(2) Regarding the second issue with locking, I'm curious about what actions you took that caused the folder to be locked.

@JusterZhu JusterZhu added the question Further information is requested label Dec 23, 2024
@yangxuilyx
Copy link
Author

yangxuilyx commented Dec 24, 2024

  1. main app should download upgrade app to update upgrade app. if set UpdateVersions = mainResp,can't download upgrade package
    image
    image

@yangxuilyx
Copy link
Author

yangxuilyx commented Dec 24, 2024

my main app had some cache directories used by main app,they are locked until the main program exit,i can't avoid this because it's used by library

@JusterZhu
Copy link
Collaborator

  1. main app should download upgrade app to update upgrade app. if set UpdateVersions = mainResp,can't download upgrade package
    image
    image

The program logic is implemented this way because they need to upgrade each other.

  1. The main program initiates the download of the upgrade program's patch package.
  2. The upgrade program downloads the patch package for the main program.

@yangxuilyx
Copy link
Author

but before modified main app download it's package self

@JusterZhu
Copy link
Collaborator

my main app had some cache directories used by main app,they are locked until the main program exit,i can't avoid this because it's used by library

This seems to be a specific issue on your end. Before merging it into the repository, I need to confirm whether everyone else is encountering this problem as well.

@JusterZhu
Copy link
Collaborator

but before modified main app download it's package self

I didn't quite understand what you meant. It seems like there might be no distinction between the patch packages for the main program and the upgrade program.

@yangxuilyx
Copy link
Author

yangxuilyx commented Dec 27, 2024

There is a difference, the main package does not include the upgrade program
The upgrade program is a separate package
Otherwise, update the upgrade program will fail due to a main program lock error.

@JusterZhu
Copy link
Collaborator

JusterZhu commented Dec 27, 2024

There is a difference, the main package does not include the upgrade program The upgrade program is a separate package Otherwise, update the upgrade program will fail due to a main program lock error.

Okay, could you provide the code? I can't reproduce this issue locally.

@JusterZhu JusterZhu added bug Something isn't working and removed question Further information is requested labels Jan 3, 2025
@JusterZhu
Copy link
Collaborator

Thank you for your submission.

@JusterZhu JusterZhu merged commit 26a3fce into GeneralLibrary:master Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants