-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored a variable name and some tests #101
Refactored a variable name and some tests #101
Conversation
LCOV of commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me! Looks like some extra functions were left in the tests that we can remove to keep things clean.
// function mockGetAverageBalanceBetween( | ||
// address _vault, | ||
// address _user, | ||
// uint48 _startTime, | ||
// uint48 _endTime, | ||
// uint256 _result | ||
// ) internal { | ||
// vm.mockCall( | ||
// address(twabController), | ||
// abi.encodeWithSelector( | ||
// TwabController.getTwabBetween.selector, | ||
// _vault, | ||
// _user, | ||
// _startTime, | ||
// _endTime | ||
// ), | ||
// abi.encode(_result) | ||
// ); | ||
// } | ||
|
||
// function mockGetAverageTotalSupplyBetween( | ||
// address _vault, | ||
// uint32 _startTime, | ||
// uint32 _endTime, | ||
// uint256 _result | ||
// ) internal { | ||
// vm.mockCall( | ||
// address(twabController), | ||
// abi.encodeWithSelector( | ||
// TwabController.getTotalSupplyTwabBetween.selector, | ||
// _vault, | ||
// _startTime, | ||
// _endTime | ||
// ), | ||
// abi.encode(_result) | ||
// ); | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could remove if we don't need these anymore
test/PrizePool.t.sol
Outdated
// function mockGetAverageBalanceBetween( | ||
// address _vault, | ||
// address _user, | ||
// uint48 _startTime, | ||
// uint48 _endTime, | ||
// uint256 _result | ||
// ) internal { | ||
// vm.mockCall( | ||
// address(twabController), | ||
// abi.encodeWithSelector( | ||
// TwabController.getTwabBetween.selector, | ||
// _vault, | ||
// _user, | ||
// _startTime, | ||
// _endTime | ||
// ), | ||
// abi.encode(_result) | ||
// ); | ||
// } | ||
|
||
// function mockGetAverageTotalSupplyBetween( | ||
// address _vault, | ||
// uint32 _startTime, | ||
// uint32 _endTime, | ||
// uint256 _result | ||
// ) internal { | ||
// vm.mockCall( | ||
// address(twabController), | ||
// abi.encodeWithSelector( | ||
// TwabController.getTotalSupplyTwabBetween.selector, | ||
// _vault, | ||
// _startTime, | ||
// _endTime | ||
// ), | ||
// abi.encode(_result) | ||
// ); | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could remove if we don't need these anymore
LCOV of commit
|
No description provided.