Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blast-compatible prize pool extension #114

Conversation

trmid
Copy link
Member

@trmid trmid commented Jun 24, 2024

Extends the prize pool and adds the following:

  • enforces that the prize token is the Blast WETH token
  • opts-in to claimable WETH yield
  • adds a function for anyone to trigger a donation of accumulated WETH yield into the prize pool

Copy link

LCOV of commit a81ed51 during Tests with 100% Coverage #556

Summary coverage rate:
  lines......: 99.8% (529 of 530 lines)
  functions..: 100.0% (83 of 83 functions)
  branches...: no data found

Files changed coverage rate:
                                             |Lines       |Functions  |Branches    
  Filename                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================
  src/extensions/BlastPrizePool.sol          | 100%     10| 100%     3|    -      0

@trmid trmid requested a review from asselstine June 27, 2024 17:24
Copy link
Contributor

@asselstine asselstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Is the Prize Pool oversize now? It was so close before!

a part of me wonders if whether making this public would have incentivized people to "push the button", but this is a good solution too.

What if we called donateClaimedYield on new draws or something? Maybe that would automate it

@trmid
Copy link
Member Author

trmid commented Jun 27, 2024

Looks good to me. Is the Prize Pool oversize now? It was so close before!

a part of me wonders if whether making this public would have incentivized people to "push the button", but this is a good solution too.

What if we called donateClaimedYield on new draws or something? Maybe that would automate it

I think every once in a while someone would come along and push the button just to see the GP number go up, but I'm not opposed to automating it either. The awardDraw function could be overridden to donate after each call, or the DrawManager on blast could be modified to do that as well.

The compile size is still good. Here's the build results:
image

@trmid trmid merged commit 800c464 into fix-review Jun 28, 2024
2 checks passed
@trmid trmid deleted the gen-1772-114-weth-has-automatic-yield-accrual-on-blast-that-is-not branch July 16, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants