Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cap prize draw range at GP period #115

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Cap prize draw range at GP period #115

merged 1 commit into from
Jun 28, 2024

Conversation

trmid
Copy link
Member

@trmid trmid commented Jun 27, 2024

No description provided.

@linear Linear
Copy link

linear bot commented Jun 27, 2024

GEN-1771 [96] vault portion start draw ID should be capped at the GP draw period

@trmid trmid requested a review from asselstine June 27, 2024 14:21
@github-actions GitHub Actions
Copy link

LCOV of commit e26d6a2 during Tests with 100% Coverage #558

Summary coverage rate:
  lines......: 99.8% (520 of 521 lines)
  functions..: 100.0% (80 of 80 functions)
  branches...: no data found

Files changed coverage rate:
                                             |Lines       |Functions  |Branches    
  Filename                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================
  src/PrizePool.sol                          |99.6%    232| 100%    46|    -      0
  src/libraries/TierCalculationLib.sol       | 100%     17| 100%     8|    -      0

@trmid trmid merged commit bf073c3 into fix-review Jun 28, 2024
2 checks passed
@sherlock-admin2 sherlock-admin2 mentioned this pull request Jun 28, 2024
Open
@trmid trmid deleted the gen-1771-96-vault-portion-start-draw-id-should-be-capped-at-the-gp branch July 15, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asselstine asselstine asselstine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trmid @asselstine