Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gen 1141 eliminate smoothing to reduce code size #87

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Gen 1141 eliminate smoothing to reduce code size #87

merged 3 commits into from
Feb 13, 2024

Conversation

asselstine
Copy link
Contributor

No description provided.

@linear Linear
Copy link

linear bot commented Feb 13, 2024

GEN-1141 Eliminate smoothing to reduce code size

@asselstine
Copy link
Contributor Author

Reduced by about 4kb!

Base automatically changed from gen-1082-add-emergency-shutdown-mode-to-the-prize-pool to main February 13, 2024 04:04
@github-actions GitHub Actions
Copy link

LCOV of commit a9cda8f during Tests with 100% Coverage #406

Summary coverage rate:
  lines......: 100.0% (401 of 401 lines)
  functions..: 100.0% (63 of 63 functions)
  branches...: no data found

Files changed coverage rate:
                                             |Lines       |Functions  |Branches    
  Filename                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================
  src/PrizePool.sol                          | 100%    173| 100%    34|    -      0
  src/libraries/DrawAccumulatorLib.sol       | 100%     62| 100%     4|    -      0

@trmid
Copy link
Member

trmid commented Feb 13, 2024

We can remove the Pair48 type since it's not used anywhere: https://github.com/GenerationSoftware/pt-v5-prize-pool/pull/87/files#diff-3398ffb061aa112967b4fca69cb5301383c3306c54dfe4a0cff4b267431c08c2R49-R54

@asselstine asselstine merged commit 448cac4 into main Feb 13, 2024
2 checks passed
@asselstine asselstine deleted the gen-1141-eliminate-smoothing-to-reduce-code-size branch February 13, 2024 17:11
@asselstine asselstine restored the gen-1141-eliminate-smoothing-to-reduce-code-size branch February 13, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asselstine @trmid