Skip binary search if observation exists #88
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In normal prize pool operations, we will have an observation for every draw except draws that had no contributions. This means that we shouldn't need to binary search for the observation in the ring buffer unless the draw had no contributions.
The following changes check to see if the draw observation has any non-zero values (available or disbursed) and if so, we can use the observation instead of binary searching for it. This should save gas in normal operating conditions.