Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Owner #91

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Removed Owner #91

merged 2 commits into from
Feb 19, 2024

Conversation

asselstine
Copy link
Contributor

No description provided.

@linear Linear
Copy link

linear bot commented Feb 14, 2024

GEN-1148 Remove Ownership from Prize Pool

@asselstine asselstine changed the title Removed DrawManager Removed Owner Feb 14, 2024
@github-actions GitHub Actions
Copy link

LCOV of commit abcfc12 during Tests with 100% Coverage #425

Summary coverage rate:
  lines......: 100.0% (395 of 395 lines)
  functions..: 100.0% (62 of 62 functions)
  branches...: no data found

Files changed coverage rate:
                                             |Lines       |Functions  |Branches    
  Filename                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================
  src/PrizePool.sol                          | 100%    169| 100%    33|    -      0

trmid
trmid requested changes Feb 15, 2024
View reviewed changes
Copy link
Member

@trmid trmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DrawManagerSet event is unused and can be removed. Otherwise, looks pretty straight-forward!

trmid
trmid reviewed Feb 15, 2024
View reviewed changes
src/PrizePool.sol
@@ -120,6 +119,7 @@ error ClaimPeriodExpired();
struct ConstructorParams {
IERC20 prizeToken;
TwabController twabController; // 160bits
address drawManager;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing drawManager natspec param

@github-actions GitHub Actions
Copy link

LCOV of commit 9387eee during Tests with 100% Coverage #431

Summary coverage rate:
  lines......: 100.0% (395 of 395 lines)
  functions..: 100.0% (62 of 62 functions)
  branches...: no data found

Files changed coverage rate:
                                             |Lines       |Functions  |Branches    
  Filename                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================
  src/PrizePool.sol                          | 100%    169| 100%    33|    -      0

@asselstine asselstine merged commit 550d1d1 into main Feb 19, 2024
2 checks passed
@asselstine asselstine deleted the gen-1148-remove-ownership-from-prize-pool branch February 19, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trmid trmid trmid requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asselstine @trmid