Added ability to donate to the prizes #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCOV of commit
|
trmid
requested changes
Feb 15, 2024
| @@ -230,6 +230,8 @@ contract PrizePool is TieredLiquidityDistributor, Ownable { | |||
| /// @notice Records the last shutdown withdrawal for an account | |||
| mapping(address vault => mapping(address user => uint24 drawId)) internal _lastShutdownWithdrawal; | |||
|
|
|||
| address public constant DONATOR = 0x000000000000000000000000000000000000F2EE; | |||
There was a problem hiding this comment.
missing natspec
Also would be nice to know why this address was chosen.
| @@ -355,6 +357,11 @@ contract PrizePool is TieredLiquidityDistributor, Ownable { | |||
| return _deltaBalance; | |||
| } | |||
|
|
|||
| function donatePrizeTokens(uint256 _amount) external { | |||
src/PrizePool.sol
Outdated
| @@ -579,7 +586,7 @@ contract PrizePool is TieredLiquidityDistributor, Ownable { | |||
| address _vault, | |||
| uint24 _startDrawIdInclusive, | |||
| uint24 _endDrawIdInclusive | |||
| ) external view returns (uint256) { | |||
| ) public view returns (uint256) { | |||
src/PrizePool.sol
Outdated
| function getDonatedBetween( | ||
| uint24 _startDrawIdInclusive, | ||
| uint24 _endDrawIdInclusive | ||
| ) public view returns (uint256) { |
LCOV of commit
|
asselstine
deleted the
gen-1081-add-ability-to-contribute-prizes-to-prize-pool
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.