Skip to content

[FEATURE] Add link-wise mask for poss and quats in multilink IK#499

Merged
ziyanx02 merged 2 commits intoGenesis-Embodied-AI:mainfrom
ziyanx02:ik
Jan 9, 2025
Merged

[FEATURE] Add link-wise mask for poss and quats in multilink IK#499
ziyanx02 merged 2 commits intoGenesis-Embodied-AI:mainfrom
ziyanx02:ik

Conversation

@ziyanx02
Copy link
Collaborator

@ziyanx02 ziyanx02 commented Jan 7, 2025

Update inverse_kinematics_multilink to allow poss and quats to contain None values, indicating that the respective property of the specified link is not considered in the IK calculation.

@ziyanx02
Copy link
Collaborator Author

ziyanx02 commented Jan 7, 2025

I'm not sure if this operation will make the function slower.

@ziyanx02 ziyanx02 closed this Jan 7, 2025
@ziyanx02 ziyanx02 reopened this Jan 7, 2025
@ziyanx02
Copy link
Collaborator Author

ziyanx02 commented Jan 7, 2025

Not sure what will happen if base link is in the list

@zhouxian
Copy link
Collaborator

zhouxian commented Jan 8, 2025

i don't like seeing not sure
you are the boss
so you'd better be sure

@ziyanx02
Copy link
Collaborator Author

ziyanx02 commented Jan 9, 2025

simplescreenrecorder-2025-01-09_14.07.17.mp4

Everything works well in my local tests.

@ziyanx02
Copy link
Collaborator Author

ziyanx02 commented Jan 9, 2025

@wangyian-me Could you review this?

@ziyanx02 ziyanx02 merged commit 5d83899 into Genesis-Embodied-AI:main Jan 9, 2025
@ziyanx02 ziyanx02 deleted the ik branch January 18, 2025 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants