[BUG FIX] Update texrepeat handling for mjcf #675
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced converting numpy array elements (
array.astype(int)
) with np.ceil operation (np.ceil(array).astype(int)
). The reason I used this operation is texrepeat values are positive.Related Issue
Resolves #616
Motivation and Context
When mjcf texrepeat is handled, it is converted to integer. That causes some issues for values such as
[0.5, 0.5]
which is rounded down to[0, 0]
. The zeros array ends up emptying the image_array at 307 and 341 ofutils/mjcf.py
.How Has This Been / Can This Be Tested?
This is a minimal example to reproduce the bug.
To test the changes in Genesis, download the zip folder from #616 and run the following:
Screenshots (if appropriate):
Checklist:
Submitting Code Changes
section of CONTRIBUTING document.