Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #11102] Faceting: prefiltering #11205

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

etj
Copy link
Contributor

@etj etj commented Jun 29, 2023

See #11102

Adjust the count of resources for facets according to filters already applied.

Filters are applied to facets and to facets/<facet_name> results by adding one or more filter{FIELD_EXPR}=VALUE query params.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #11205 (63aedd7) into master (8838b8e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11205      +/-   ##
==========================================
+ Coverage   61.23%   61.26%   +0.02%     
==========================================
  Files         839      839              
  Lines       51856    51877      +21     
  Branches     6655     6658       +3     
==========================================
+ Hits        31755    31783      +28     
+ Misses      18570    18563       -7     
  Partials     1531     1531              

@mattiagiupponi mattiagiupponi added this to the 4.2.0 milestone Jun 29, 2023
@mattiagiupponi mattiagiupponi merged commit f3a490a into master Jun 29, 2023
10 checks passed
@mattiagiupponi mattiagiupponi deleted the 11102-faceting-prefiltering branch June 29, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants