Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master minor fixes #11295

Closed
wants to merge 12 commits into from
Closed

Master minor fixes #11295

wants to merge 12 commits into from

Conversation

afabiani
Copy link
Member

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jul 27, 2023
@afabiani afabiani marked this pull request as draft July 27, 2023 08:57
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #11295 (c5419fc) into master (d95db9f) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11295      +/-   ##
==========================================
- Coverage   60.62%   60.61%   -0.01%     
==========================================
  Files         858      858              
  Lines       52568    52568              
  Branches     6723     6723              
==========================================
- Hits        31867    31865       -2     
- Misses      19166    19169       +3     
+ Partials     1535     1534       -1     

@afabiani afabiani marked this pull request as ready for review July 27, 2023 12:53
@afabiani afabiani marked this pull request as draft August 18, 2023 10:09
@afabiani afabiani closed this Aug 23, 2023
@afabiani afabiani deleted the master_minor_fixes branch August 23, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant