Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new env variable GEOIP_DATABASE_URL #11300

Closed
wants to merge 4 commits into from

Conversation

NyakudyaA
Copy link
Contributor

Fixes #11263

Even though you can a database and use the env variable GEOIP_PATH=/mnt/volumes/statics/geoip.db when deploying using CDI i.e Argo CD you have no option to mount volumes with a local DB

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jul 30, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #11300 (3bee083) into master (4861375) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11300   +/-   ##
=======================================
  Coverage   60.55%   60.55%           
=======================================
  Files         846      846           
  Lines       52477    52477           
  Branches     6722     6722           
=======================================
  Hits        31777    31777           
  Misses      19165    19165           
  Partials     1535     1535           

@giohappy
Copy link
Contributor

giohappy commented Aug 8, 2023

@NyakudyaA the updategeoip functionality was just dropped since it was a very old method that is not allowed anymore by MaxMind EULA.
I think the GEOIP_PATH should be enough to reference the DB location, isn't it?

@NyakudyaA
Copy link
Contributor Author

@NyakudyaA the updategeoip functionality was just dropped since it was a very old method that is not allowed anymore by MaxMind EULA. I think the GEOIP_PATH should be enough to reference the DB location, isn't it?

Not in all cases, in our case we are deploying through ArgoCD and we cannot mount the DB so we would prefer to have a working link to download the DB and if the link is not available/working we can still provide our own custom link to download the DB

@giohappy
Copy link
Contributor

giohappy commented Aug 8, 2023

Not in all cases, in our case we are deploying through ArgoCD and we cannot mount the DB so we would prefer to have a working link to download the DB and if the link is not available/working we can still provide our own custom link to download the DB

Out of curiosity:

  • are you using the monitoring module?
  • do you need to execute regular updates of the GeoIP DB?

@NyakudyaA
Copy link
Contributor Author

Not in all cases, in our case we are deploying through ArgoCD and we cannot mount the DB so we would prefer to have a working link to download the DB and if the link is not available/working we can still provide our own custom link to download the DB

Out of curiosity:

* are you using the monitoring module?

* do you need to execute regular updates of the GeoIP DB?

We do use monitoring module. We rarely execute updates on the GeoIP DB. If the updategeoip method has been dropped maybe I can take a look and see if we still need this. Maybe if you can fix the URL to be correct then we can close this PR

@giohappy
Copy link
Contributor

Maybe if you can fix the URL to be correct then we can close this PR

@NyakudyaA the GeoIP 2 DB can not be shared, it violates MaxMind EULA. You need your own copy of the DB and set the GEOIP_PATH to your convenience.
If you don't need to do frequent updates you could ship it inside your Docker image.

@NyakudyaA
Copy link
Contributor Author

No longer useful since monitoring has been dropped

@NyakudyaA NyakudyaA closed this Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link for downloading GeoLite2-City.tar.gz is not working
3 participants