Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #11554] Implement WMTS backgrounds for thumbnails (only 3857 tilematrix sets) #11555

Merged
merged 5 commits into from
Oct 5, 2023

Conversation

giohappy
Copy link
Contributor

@giohappy giohappy commented Oct 3, 2023

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@giohappy giohappy added this to the 4.2.0 milestone Oct 3, 2023
@giohappy giohappy self-assigned this Oct 3, 2023
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Oct 3, 2023
@giohappy giohappy linked an issue Oct 3, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #11555 (b0fa447) into master (9f88645) will decrease coverage by 0.23%.
The diff coverage is 6.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11555      +/-   ##
==========================================
- Coverage   62.34%   62.12%   -0.23%     
==========================================
  Files         868      869       +1     
  Lines       51786    51992     +206     
  Branches     6475     6491      +16     
==========================================
+ Hits        32287    32301      +14     
- Misses      17944    18136     +192     
  Partials     1555     1555              

@giohappy giohappy merged commit e65f4a4 into master Oct 5, 2023
15 of 17 checks passed
@giohappy giohappy deleted the issue_11554 branch October 5, 2023 12:13
@giohappy giohappy changed the title [Fixes #11554] Implement WMTS backgrounds for thumbnails (only 3857 tilematricsets) [Fixes #11554] Implement WMTS backgrounds for thumbnails (only 3857 tilematrix sets) Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WMTS backgrounds for thumbnails
1 participant