Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set geonode-importer==1.0.9 on branch 4.2.x #12464

Open
wants to merge 1 commit into
base: 4.2.x
Choose a base branch
from

Conversation

lordakarias
Copy link

@lordakarias lordakarias commented Jul 31, 2024

4.2.x is the suggested branch on GeoNode Vanilla documentation

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

4.2.x is the suggested branch on GeoNode Vanilla documentation
Copy link

cla-bot bot commented Jul 31, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @lordakarias on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.23%. Comparing base (5a3576d) to head (b15a568).

Additional details and impacted files
@@           Coverage Diff           @@
##            4.2.x   #12464   +/-   ##
=======================================
  Coverage   63.22%   63.23%           
=======================================
  Files         877      877           
  Lines       52587    52587           
  Branches     6596     6596           
=======================================
+ Hits        33249    33251    +2     
+ Misses      17823    17820    -3     
- Partials     1515     1516    +1     

@giohappy
Copy link
Contributor

4.2.x is the suggested branch on GeoNode Vanilla documentation

@lordakarias would you kindly show me where this is stated?
4.2.x branch reached EOL and is not maintained anymore.

@lordakarias
Copy link
Author

@giohappy

On Section 2 of the following document: https://docs.geonode.org/en/master/install/advanced/core/index.html

image

@lordakarias
Copy link
Author

4.2.x is the suggested branch on GeoNode Vanilla documentation

@lordakarias would you kindly show me where this is stated? 4.2.x branch reached EOL and is not maintained anymore.

@giohappy will there be an update to the document?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants