Fixes #12533 Handled incorrect referencing of contacts for ISO Metadata.

[ahmdthr]

The full_metadata.xml file is referring to an incorrect property of the resource base. The generated metadata didn't include contacts, which is fixed now.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

• Confirm you have read the contribution guidelines
• You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
• Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

• There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
• The issue connected to the PR must have Labels and Milestone assigned
• PR for bug fixes and small new features are presented as a single commit
• Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
• New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
• This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
• This PR passes the QA checks: black geonode && flake8 geonode
• Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
• Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.26%. Comparing base (55a3725) to head (4ee7210).
Report is 7 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #12548   +/-   ##
=======================================
  Coverage   64.26%   64.26%           
=======================================
  Files         888      888           
  Lines       53610    53610           
  Branches     6606     6606           
=======================================
+ Hits        34451    34452    +1     
+ Misses      17650    17649    -1     
  Partials     1509     1509           

[giohappy]

@ahmdthr we need to grant a minimal quality check. Your commit message contains a typo, please fix it.

[ridoo]

@giohappy any reason for just closing this PR? Did you fix it elsewhere already?

It's still wrongly referenced here:

geonode/geonode/catalogue/templates/catalogue/full_metadata.xml

Line 16 in 5bcbd82

{% for contact_roles, label in layer.get_defined_contact_roles %}

See here:

geonode/geonode/base/models.py

Lines 1767 to 1778 in 5bcbd82

	def get_defined_multivalue_contact_roles(self) -> List[Tuple[List[settings.AUTH_USER_MODEL], str]]:
	"""Returns all set contact roles of the ressource with additional ROLE_VALUES from geonode.people.enumarations.ROLE_VALUES. Mainly used to generate output xml more easy.
	Returns:
	_type_: List[Tuple[List[people object], roles_label_name]]
	_description: list tuples including two elements: 1. list of people have a certain role. 2. role label
	"""
	return {
	role.label: self.__getattribute__(role.name)
	for role in Roles.get_multivalue_ones()
	if self.__getattribute__(role.name)
	}