fix(Mesh): add helpers to remove elements having same vertices #1182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BotellaA
reviewed
Sep 11, 2025
Comment on lines
+102
to
+108
| DEBUG( "Mobius strip detected" ); | ||
| DEBUG( cur_polygon ); | ||
| DEBUG( e ); | ||
| SDEBUG( adj.value() ); | ||
| SDEBUG( mesh_.polygon_barycenter( cur_polygon ) ); | ||
| SDEBUG( | ||
| mesh_.polygon_barycenter( adj->polygon_id ) ); |
Comment on lines
+80
to
+81
| template < typename Mesh, typename Builder > | ||
| void remove_element_duplication( const Mesh& mesh, Builder& builder ) |
There was a problem hiding this comment.
Suggested change
| template < typename Mesh, typename Builder > | |
| void remove_element_duplication( const Mesh& mesh, Builder& builder ) | |
| template < typename Mesh > | |
| void remove_element_duplication( const Mesh& mesh, typename Mesh::Builder& builder ) |
| } | ||
| const auto element_vertices = | ||
| accessor.element_vertices( element_id ); | ||
| std::vector< geode::index_t > common_elements = |
There was a problem hiding this comment.
Suggested change
| std::vector< geode::index_t > common_elements = | |
| auto common_elements = |
| } | ||
| } | ||
| } | ||
| delete_elements( to_delete, builder ); |
There was a problem hiding this comment.
Return the mapping between input mesh and output mesh ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.