Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve command add jsondecodeerror #190

Merged
merged 2 commits into from
Jul 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions georiviere/observations/management/commands/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import json
import requests

from django.core.management.base import BaseCommand, CommandError
Expand Down Expand Up @@ -47,9 +48,11 @@ def handle(self, *args, **options):

if verbosity >= 2:
self.stdout.write('Get station from API {0}'.format(response.url))

response_content = response.json()

try:
response_content = response.json()
except json.JSONDecodeError:
self.stdout.write('Response is not a json')
return
if verbosity >= 1:
self.stdout.write('Import {1} stations from API {0}'.format(response.url, response_content['count']))

Expand All @@ -60,6 +63,10 @@ def handle(self, *args, **options):
response = requests.get(response_content['next'])
if verbosity >= 2:
self.stdout.write('Import next page from {0}'.format(response.url))
response_content = response.json()
try:
response_content = response.json()
except json.JSONDecodeError:
self.stdout.write('Response is not a json')
return
results = response_content['data']
self.create_or_update_stations(results, verbosity, with_parameters)
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from datetime import datetime
import json
import requests
from django.contrib.gis.geos import Point
from georiviere.observations.models import Station, StationProfile, Parameter, ParameterTracking, Unit
Expand Down Expand Up @@ -57,7 +58,11 @@ def create_or_update_stations(self, results, verbosity, with_parameters=False):
except requests.exceptions.ConnectionError as e:
self.stdout.write(f'Limit of connection has been exceeded {e}')
continue
response_firstpage_content = response_firstpage.json()
try:
response_firstpage_content = response_firstpage.json()
except json.JSONDecodeError:
self.stdout.write('Response is not a json')
continue
indices_data = response_firstpage_content['data']

for indice in indices_data:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from datetime import datetime
import json
import requests
from django.contrib.gis.geos import Point
from georiviere.observations.models import Station, StationProfile, Parameter, ParameterTracking, Unit
Expand Down Expand Up @@ -67,7 +68,11 @@ def create_or_update_stations(self, results, verbosity, with_parameters=False):
except requests.exceptions.ConnectionError as e:
self.stdout.write(f'Limit of connection has been exceeded {e}')
continue
response_firstpage_content = response_firstpage.json()
try:
response_firstpage_content = response_firstpage.json()
except json.JSONDecodeError:
self.stdout.write('Response is not a json')
continue
analysepc_data = response_firstpage_content['data']

# If there is more than one page, get data desc sorted
Expand All @@ -78,7 +83,11 @@ def create_or_update_stations(self, results, verbosity, with_parameters=False):
except requests.exceptions.ConnectionError as e:
self.stdout.write(f'Limit of connection has been exceeded {e}')
continue
response_desc_data = response_desc_results.json()['data']
try:
response_desc_data = response_desc_results.json()['data']
except json.JSONDecodeError:
self.stdout.write('Response is not a json')
continue
analysepc_data = analysepc_data + response_desc_data

for measure in analysepc_data:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"first": "https://hubeau.eaufrance.fr/api/v1/hydrobio/indices?code_station_hydrobio=06000874&page=1&size=1000",
"last": null,
"prev": null,
"next": null,
"next": "https://hubeau.eaufrance.fr/api/v1/hydrobio/indices?code_station_hydrobio=06000874&page=3&size=1000",
"api_version": "1.0.0",
"data": [
{
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"count": 0,
"first": "https://hubeau.eaufrance.fr/api/v1/hydrobio/indices?code_station_hydrobio=06000874&page=2&size=1000",
"last": null,
"prev": null,
"next": "",
"api_version": "1.0.0",
"data": []
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"first": "https://hubeau.eaufrance.fr/api/v1/hydrobio/stations_hydrobio?code_station_hydrobio=06000874&page=1&size=1000",
"last": null,
"prev": null,
"next": null,
"next": "https://hubeau.eaufrance.fr/api/v1/hydrobio/stations_hydrobio?code_station_hydrobio=06000874&page=3&size=1000",
"api_version": "1.0.0",
"data": [
{
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"count": 0,
"first": "https://hubeau.eaufrance.fr/api/v1/hydrobio/stations_hydrobio?code_station_hydrobio=06000874&page=2&size=1000",
"last": null,
"prev": null,
"next": "",
"api_version": "1.0.0",
"data": []
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"first": "https://hubeau.eaufrance.fr/api/v1/hydrobio/taxons?code_station_hydrobio=06000874&page=1&size=1000",
"last": null,
"prev": null,
"next": null,
"next": "https://hubeau.eaufrance.fr/api/v1/hydrobio/taxons?code_station_hydrobio=06000874&page=3&size=1000",
"api_version": "1.0.0",
"data": [
{
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"count": 45,
"first": "https://hubeau.eaufrance.fr/api/v1/hydrobio/taxons?code_station_hydrobio=06000874&page=1&size=1000",
"last": null,
"prev": null,
"next": null,
"api_version": "1.0.0",
"data": []
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"first": "https://hubeau.eaufrance.fr/api/v1/hydrometrie/referentiel/stations?code_site=U2012010&code_site=U2015410&format=json&page=1&size=20",
"last": null,
"prev": null,
"next": null,
"next": "https://hubeau.eaufrance.fr/api/v1/hydrometrie/referentiel/stations?code_site=U2012010&code_site=U2015410&format=json&page=3&size=20",
"api_version": "1.0.1",
"data": [
{
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"count": 2,
"first": "https://hubeau.eaufrance.fr/api/v1/hydrometrie/referentiel/stations?code_site=U2012010&code_site=U2015410&format=json&page=2&size=20",
"last": null,
"prev": null,
"next": null,
"api_version": "1.0.1",
"data": [
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"first": "https://hubeau.eaufrance.fr/api/v1/qualite_rivieres/station_pc?format=json&code_departement=11&page=1&size=1000",
"last": null,
"prev": null,
"next": null,
"next": "https://hubeau.eaufrance.fr/api/v1/qualite_rivieres/station_pc?format=json&code_departement=11&page=3&size=1000",
"api_version": "1.1.0",
"data": [
{
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"count": 28,
"first": "https://hubeau.eaufrance.fr/api/v1/qualite_rivieres/station_pc?format=json&code_departement=11&page=2&size=1000",
"last": null,
"prev": null,
"next": null,
"api_version": "1.1.0",
"data": []
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"first": "https://hubeau.eaufrance.fr/api/v1/temperature/station?format=json&code_commune=25320&code_commune=25415&page=1&size=1000",
"last": null,
"prev": null,
"next": null,
"next": "https://hubeau.eaufrance.fr/api/v1/temperature/station?format=json&code_commune=25320&code_commune=25415&page=3&size=1000",
"api_version": "1.0.0",
"data": [
{
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"count": 0,
"first": "https://hubeau.eaufrance.fr/api/v1/temperature/station?format=json&code_commune=25320&code_commune=25415&page=2&size=1000",
"last": null,
"prev": null,
"next": "",
"api_version": "1.0.0",
"data": []
}
Loading