Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSS of Altimetry #210

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Update CSS of Altimetry #210

merged 3 commits into from
Sep 1, 2023

Conversation

Huquette
Copy link
Contributor

This pull request changes how altitude profiles look. Right now, they look like this:

OLD_ALTIMETRY_GEOR

OLD_ALTIMETRY_GEOR2

After this change, they will look like this:

NEW_ALTIMETRY_GEOR

NEW_ALTIMETRY_GEOR2

As a result, the altitude profile will show higher up on the page, which let some space for the attribution mark.

@Huquette Huquette self-assigned this Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #210 (0daeb1d) into master (f3d4121) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #210   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files         157      157           
  Lines        5429     5429           
=======================================
  Hits         5363     5363           
  Misses         66       66           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@babastienne
Copy link
Member

@Huquette the PR seems good to me. I'd like to test the feature before approving the merge. I suggest we discuss it this afternoon to test it, especially in mobile / tablet views and if it's concluant you'll merge.

@Huquette Huquette merged commit 8b7edcb into master Sep 1, 2023
8 checks passed
@Huquette Huquette deleted the fix_altimetry_css branch September 1, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants