Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extents updates #91

Merged
merged 14 commits into from
Sep 24, 2024
Merged

Extents updates #91

merged 14 commits into from
Sep 24, 2024

Conversation

erialC-P
Copy link
Collaborator

@erialC-P erialC-P commented Sep 23, 2024

Method changes:

  • Connectivity is calculated early in the workflow, and used as a mask for the entire analysis - e.g. pixels outside of the coastal mask are never used to calculate elevation or extents in the first place (vs. the original approach of running the elevation workflow on a larger set of input pixels then clipping the outputs at the end of the workflow). This is faster and more efficient - plus we can re-use the same connectivity output in the Extents analysis too
  • Frequency is the only exception to the above - it's now calculated across the entire tile extent (v.s. being clipped to excluded deep ocean pixels). This makes it more useful for Extents analysis - we don't need to treat missing nodata pixels over deep water differently)
  • Switched to improved ensemble tide modelling coast from dea_tools (will be replaced by eo-tides in the future)

Other:

  • Updated requirements to more recent packages

Copy link

For full integration test results, refer to the Tests directory README.

Copy link
Collaborator

@vnewey vnewey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@robbibt robbibt merged commit 772a95c into develop Sep 24, 2024
@robbibt robbibt deleted the extents_updates branch September 24, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants