Fix MenuItem title max length in flatpages migration 0010 (#4095) #4096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) I have missed a spot when providing the fix on title length at e59cc89
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix-open-in-new-tab-when-no-target #4096 +/- ##
===================================================================
Coverage 98.39% 98.39%
===================================================================
Files 284 284
Lines 20796 20796
===================================================================
Hits 20462 20462
Misses 334 334 ☔ View full report in Codecov by Sentry. |
Passing run #8846 ↗︎
Details:
Review all test suite changes for PR #4096 ↗︎ |
|||||||||||||||
babastienne
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have missed a spot when providing the fix on title length at e59cc89
Related Issue
Error with migration to MenuItem: value too long for type character varying(50)
Checklist
I have followed the guidelines in our Contributing documentMy code respects the Definition of done available in the Development section of the documentationI have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature works.