Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to filter flatpages by portal #4097

Merged
merged 1 commit into from
May 7, 2024

Conversation

marcantoinedupre
Copy link
Contributor

@marcantoinedupre marcantoinedupre commented May 6, 2024

...on the admin list of flatpages.

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

on the admin list of flatpages.
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.39%. Comparing base (35a9fce) to head (7a40cac).

Additional details and impacted files
@@                        Coverage Diff                         @@
##           fix-menu-item-length-in-migration    #4097   +/-   ##
==================================================================
  Coverage                              98.39%   98.39%           
==================================================================
  Files                                    284      284           
  Lines                                  20796    20796           
==================================================================
  Hits                                   20462    20462           
  Misses                                   334      334           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented May 6, 2024

Passing run #8848 ↗︎

0 24 0 0 Flakiness 0

Details:

Merge 7a40cac into 35a9fce...
Project: Geotrek-admin Commit: 94d2e5b8e2 ℹ️
Status: Passed Duration: 02:16 💡
Started: May 6, 2024 2:20 PM Ended: May 6, 2024 2:22 PM

Review all test suite changes for PR #4097 ↗︎

@marcantoinedupre marcantoinedupre marked this pull request as ready for review May 6, 2024 14:34
Base automatically changed from fix-menu-item-length-in-migration to master May 7, 2024 12:23
@marcantoinedupre marcantoinedupre merged commit cf65939 into master May 7, 2024
16 checks passed
@marcantoinedupre marcantoinedupre deleted the impr-can-filter-flatpages-by-portals branch May 7, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants