Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v_treks view duplicated when multiple sources (refs #4099) #4100

Merged
merged 1 commit into from
May 17, 2024

Conversation

amandine-sahl
Copy link
Contributor

@amandine-sahl amandine-sahl commented May 7, 2024

Description

Correction jointure dans la vue v_treks

Related Issue

#4099

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@amandine-sahl amandine-sahl force-pushed the fix/v_treks branch 2 times, most recently from 828fd29 to 6c32f91 Compare May 7, 2024 13:16
Copy link

cypress bot commented May 7, 2024

Passing run #8916 ↗︎

0 24 0 0 Flakiness 0

Details:

Merge cf39d3e into 4bd5078...
Project: Geotrek-admin Commit: 88d046f813 ℹ️
Status: Passed Duration: 02:11 💡
Started: May 16, 2024 2:52 PM Ended: May 16, 2024 2:54 PM

Review all test suite changes for PR #4100 ↗︎

@babastienne babastienne changed the title Fix v_treks view Fix v_treks view duplicated when multiple sources (refs #4099) May 7, 2024
@marcantoinedupre
Copy link
Contributor

Il y a un conflit avec le changelog. Peux-tu rebase ta branche sur master ?

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.40%. Comparing base (3ae73b5) to head (cf39d3e).
Report is 30 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4100   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files         284      284           
  Lines       20784    20784           
=======================================
  Hits        20453    20453           
  Misses        331      331           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@submarcos submarcos merged commit 7ffdae2 into GeotrekCE:master May 17, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants