Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Bug] Fix missing Dockerfile path on make build scripts (fix #4365) #4366

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

lpofredc
Copy link
Contributor

Description

Fix Makefile build scripts by adding missing Dockerfilepath variable todocker build`.

Command standardization by replacing dash with underscore.

Related Issue

#4365

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@lpofredc lpofredc marked this pull request as ready for review November 13, 2024 16:01
Copy link

cypress bot commented Nov 13, 2024

Geotrek-admin    Run #10311

Run Properties:  status check passed Passed #10311  •  git commit 12d22cf5d2: :bug: [Bug] Fix missing Dockerfile path on make build scripts (fix #4365)
Project Geotrek-admin
Branch Review master
Run status status check passed Passed #10311
Run duration 02m 23s
Commit git commit 12d22cf5d2: :bug: [Bug] Fix missing Dockerfile path on make build scripts (fix #4365)
Committer lpofredc
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

Copy link

cypress bot commented Nov 13, 2024

Geotrek-admin    Run #10313

Run Properties:  status check passed Passed #10313  •  git commit f5d85e23ad ℹ️: Merge 49d9afc355788f791c1342839b513b5efc4e8934 into 18b3657e8f32b152e97900128056...
Project Geotrek-admin
Branch Review refs/pull/4366/merge
Run status status check passed Passed #10313
Run duration 02m 10s
Commit git commit f5d85e23ad ℹ️: Merge 49d9afc355788f791c1342839b513b5efc4e8934 into 18b3657e8f32b152e97900128056...
Committer Fred C
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

@submarcos submarcos linked an issue Nov 14, 2024 that may be closed by this pull request
@submarcos
Copy link
Member

Ok merci, je merge même si y'a un pb de CI qui n'envoie pas la couverture, mais la modif n'impacte en rien le code

@submarcos submarcos merged commit b89ae96 into GeotrekCE:master Nov 14, 2024
15 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Missing Dockerfile path value on make build/build-no-cache
2 participants