Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction pagination asynchrone #48

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Conversation

amandine-sahl
Copy link
Collaborator

@amandine-sahl amandine-sahl commented Jul 20, 2023

cf #41, #49

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.43 🎉

Comparison is base (81caae9) 78.75% compared to head (2135a1e) 80.19%.

Additional details and impacted files
@@              Coverage Diff               @@
##           develop_v2      #48      +/-   ##
==============================================
+ Coverage       78.75%   80.19%   +1.43%     
==============================================
  Files              10       10              
  Lines             951      934      -17     
==============================================
  Hits              749      749              
+ Misses            202      185      -17     
Flag Coverage Δ
pytest 80.19% <100.00%> (+1.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
backend/config/conftest.py 100.00% <100.00%> (ø)
backend/core/models.py 94.31% <100.00%> (+0.02%) ⬆️
backend/core/repository.py 100.00% <100.00%> (+41.17%) ⬆️
backend/core/routes.py 56.84% <100.00%> (+0.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@mdartic mdartic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci !
Un oubli de ma part... avec peu d'événements, je n'avais pas fait attention à cette partie.
Je t'ai fait une suggestion sur l'écriture, sens toi libre de la prendre ou non.
C'est ok pour moi !

front-vite/src/views/EventListingView.vue Outdated Show resolved Hide resolved
Co-authored-by: Mathieu DARTIGUES <mathieu@dartic.fr>
@amandine-sahl amandine-sahl merged commit d6dcdf3 into develop_v2 Jul 20, 2023
@amandine-sahl amandine-sahl deleted the fix/eventPaginator branch July 20, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants