Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the itinerancyStep display on the map #1259

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Fix the itinerancyStep display on the map #1259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions frontend/src/components/pages/details/Details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,10 +654,10 @@
trekFamily={trekFamily}
trekChildrenGeometries={details.children.reduce<TrekChildGeometry[]>(
(children, currentChild) => {
if (currentChild.childGeometry) {
if (currentChild.childrenGeometries) {
children.push({
...currentChild.childGeometry,
id: `TREK-${currentChild.childGeometry.id}`,
...currentChild.childrenGeometries,
id: `TREK-${currentChild.childrenGeometries.id}`,
});
}
return children;
Expand Down Expand Up @@ -706,7 +706,7 @@
)}
</>
),
[

Check warning on line 709 in frontend/src/components/pages/details/Details.tsx

View workflow job for this annotation

GitHub Actions / install-and-test 

React Hook useMemo has missing dependencies: 'anchors', 'handleViewPointClick', 'hasNavigator', 'sectionRef', 'sections', and 'setMapId'. Either include them or remove the dependency array
details,
displayAltimetricProfile,
displayMobileMap,
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/modules/details/interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ export interface Bbox {
}

export interface TrekResultWithGeometryChild extends TrekResult {
childGeometry?: TrekChildGeometry;
childrenGeometries?: TrekChildGeometry;
}
export interface RawTrekChildGeometry {
geometry: RawLineStringGeometry3D | RawMultiLineStringGeometry3D | RawPointGeometry3D;
Expand Down
Loading