Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error with newer clang #13

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

ihaveamac
Copy link
Contributor

Build failed with clang 19 due to integer promotion.

/tmp/rvthtool/src/rvthtool/verify.cpp:99:7: error: format specifies type 'unsigned int' but the argument has type 'int' [-Werror,-Wformat]
   97 |                                         printf("\n*** ERROR: Pt%u [%u,%u,%u%s]: H%u hash is invalid.\n",
      |                                                                       ~~
      |                                                                       %d
   98 |                                                 state->pt_current, state->group_cur,
   99 |                                                 state->sector / 8, state->sector,
      |                                                 ^~~~~~~~~~~~~~~~~
/tmp/rvthtool/src/rvthtool/verify.cpp:105:7: error: format specifies type 'unsigned int' but the argument has type 'int' [-Werror,-Wformat]
  103 |                                         printf("\n*** ERROR: Pt%u [%u,%u,%u%s]: H%u table copy doesn't match base sector.\n",
      |                                                                       ~~
      |                                                                       %d
  104 |                                                 state->pt_current, state->group_cur,
  105 |                                                 state->sector / 8, state->sector,
      |                                                 ^~~~~~~~~~~~~~~~~

Build failed with clang 19 due to integer promotion.
@GerbilSoft GerbilSoft merged commit 3c240dd into GerbilSoft:master Feb 1, 2025
1 check passed
@GerbilSoft
Copy link
Owner

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants