Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-platform support for getting a home directory path #71

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

suminb
Copy link

@suminb suminb commented Mar 28, 2023

Although GerevAI is most likely going to be running on a Linux environment, it would still be nice to be able to run it on other environments such as macOS or Windows for development and/or testing purposes. This can be achieved by simply replacing /home/{os.getlogin() with Path.home(). I've noticed pathlib.Path is already in use, so we might as well use it to get the home directory path for the current user.

@Roey7
Copy link
Contributor

Roey7 commented Mar 30, 2023

Have you tested that locally + inside a docker?

@yuvalsteuer
Copy link
Contributor

@suminb , hi have you tested this? could you screenshot a working example.

@suminb
Copy link
Author

suminb commented Apr 12, 2023

I haven't tested this inside a Docker. I'll show a screenshot when I test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants