Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile UI build stage #83

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Dockerfile UI build stage #83

wants to merge 18 commits into from

Conversation

Itaykal
Copy link
Contributor

@Itaykal Itaykal commented Mar 31, 2023

Added a builder stage for the UI instead of doing it externally in a script.

@Itaykal Itaykal self-assigned this Mar 31, 2023
@Itaykal
Copy link
Contributor Author

Itaykal commented Mar 31, 2023

I changed the docker cache type from gha to local, the Docker docs say that gha cache exporting is experimental.
Local has its own problems - The cache never clears itself so it must be removed, I added a step that does that as a temp fix

@Itaykal
Copy link
Contributor Author

Itaykal commented Mar 31, 2023

Drafting the PR, I have some testing to do with the cache, I want to see if it works as intended and expected

@Itaykal Itaykal marked this pull request as draft March 31, 2023 15:33
@Itaykal
Copy link
Contributor Author

Itaykal commented Mar 31, 2023

I changed the docker cache type from gha to local, the Docker docs say that gha cache exporting is experimental. Local has its own problems - The cache never clears itself so it must be removed, I added a step that does that as a temp fix

I tried to understand the differance between them and sounds like gha could be better, reverted

@Itaykal
Copy link
Contributor Author

Itaykal commented Mar 31, 2023

Disclaimer: The first run will be 30 minutes or so because nothing is cached

@Itaykal Itaykal marked this pull request as ready for review March 31, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants