Remove node-sass and fix footer test (#111)

GetDKAN · Sep 29, 2022 · fa8f9f5 · fa8f9f5
1 parent 785ef54
commit fa8f9f5
Show file tree

Hide file tree

Showing 5 changed files with 43,810 additions and 12 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -3,10 +3,10 @@ jobs:
   build:
     parallelism: 1
     machine:
-      image: circleci/classic:latest
+      image: ubuntu-2004:current
     environment:
       TEST_RESULTS: /tmp/test-results
-      DKTL_VERSION: "4.2.4"
+      DKTL_VERSION: "4.2.11"
     steps:
       - checkout
       - run:
@@ -19,6 +19,7 @@ jobs:
           command: |
             cd .. &&  mv project frontend
             mkdir project
+
       - run:
           name: Create DKAN site with frontend; run tests
           command: |
@@ -29,8 +30,6 @@ jobs:
             mv ../frontend src
             dktl frontend:install
             dktl frontend:build
-            dktl drush config-set frontend.config build_folder '/build' -y
-            dktl drush config-set frontend.config frontend_path '/frontend' -y
             dktl frontend:test
       - store_artifacts:
           path: src/frontend/cypress/screenshots

diff --git a/cypress/integration/home.spec.js b/cypress/integration/home.spec.js
@@ -30,7 +30,7 @@ context('Home', () => {
       'Gold Prices in London 1950-2008 (Monthly)',
       'Afghanistan Election Districts',
     ];
-    
+
     regionLinks.forEach((text) => cy.findByRole('heading', { name: text }));
   })
 
@@ -45,7 +45,9 @@ context('Home', () => {
       'Drupal',
       'Open Source Open Data',
     ];
-    footerLinks.forEach((text) => cy.findByRole('link', { name: text }))
+    cy.get('.dc-footer').within(() => {
+      footerLinks.forEach((text) => cy.findByRole('link', { name: text }).should('exist'))
+    })
   })
 
 })