Fixes striping and loading state of dataset page/tables #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexiscott
approved these changes
Feb 9, 2021
dgading
added a commit
that referenced
this pull request
Feb 26, 2021
alex-ahumada
pushed a commit
to aytodecadiz/cadiz-data-catalog-app
that referenced
this pull request
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This along with the linked component PR should address the styling and loading state on the dataset page. The zebra striping was off because when you have an overflow set, the css is only calculated by the width visible. So I just removed the box shadow from the table headers so it didn't look off and applied the hover and odd row styling to the cells instead of the row.
GetDKAN/data-catalog-components#81
GetDKAN/data-catalog-components#114