-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x rc1 #165
Open
dgading
wants to merge
33
commits into
main
Choose a base branch
from
2.x-rc1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update to files to get Rollup working * Move react scripts to devDependenies * Comment out React strap components * Modify files needed to make rollup work
* Add USWDS Card component * Update button action to null by default * Adds Organization component with docz and tests * Move PublisherList to templates and set with best practice for ease of use
* Initial new datatable and results * Add tests to Datatable * Add proptypes to datatable * Add basic story for DataTable * Remove some debug statements from tests
* Comment out datastore since it is not used * Fix tests for DatatableDensity and SearchListItem * Fix propTypes and tests for DataTablePageResults * Add basic test to DatasetSearcCard * Skip tests on navbar as component needs to be replaced with non Bootstrap * Skip test as inputs are removed currently as they are being replaced with non bootstrap * Skip and fix some toggle block tests * Update or skip tests on Search Input, Result Message, and SHow more'
* Update the API Docs to work like PDC when calling data * Remove test for now
* Add some fetch tests to apidocs and fix proptypes * Remove fetch count since it doesn't reset automatically * Updated prop from number to string. Co-authored-by: Brian Seek <brian.seek@civicactions.com>
* Fix results from showing 1-0 and to many on last page of table * Add custom loading/no results props to datatable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.