refactor(llc, core, ui): update X-Stream-Client header for enhanced client identification #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2131 +/- ##
==========================================
- Coverage 60.49% 60.47% -0.02%
==========================================
Files 382 384 +2
Lines 23782 23827 +45
==========================================
+ Hits 14386 14410 +24
- Misses 9396 9417 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
renefloor
reviewed
Mar 7, 2025
Comment on lines
+11
to
+17
| SystemEnvironmentManager({ | ||
| SystemEnvironment environment = const SystemEnvironment( | ||
| sdkName: 'stream-chat', | ||
| sdkIdentifier: 'dart', | ||
| sdkVersion: PACKAGE_VERSION, | ||
| ), | ||
| }) : _environment = environment; |
There was a problem hiding this comment.
We don't want to have people change these values. What do you think of creating 2 constructors like this? (simplified)
Suggested change
| SystemEnvironmentManager({ | |
| SystemEnvironment environment = const SystemEnvironment( | |
| sdkName: 'stream-chat', | |
| sdkIdentifier: 'dart', | |
| sdkVersion: PACKAGE_VERSION, | |
| ), | |
| }) : _environment = environment; | |
| SystemEnvironmentManager.llc() : sdkIdentifier = 'dart'; | |
| SystemEnvironmentManager.core() : sdkIdentifier = 'core'; | |
| SystemEnvironmentManager.flutter() : sdkIdentifier = 'flutter'; |
For Core and Flutter I would add an AppConfig parameter, which only contains the app specific settings, such as appName and appVersion. We can make more variables required there.
| String? deviceModel; | ||
|
|
||
| try { | ||
| switch (CurrentPlatform.type) { |
There was a problem hiding this comment.
Following my other comment, I would move this to an AppConfig class which can be used both by core and flutter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: FLU-31
Description of the pull request
Aligned the
X-Stream-Clientheader with the other SDK's based on the notion doc.