Skip to content

Feature/upgrade dependencies#23

Merged
valdisiljuconoks merged 11 commits intoGeta:masterfrom
CodeArtDK:feature/upgrade-dependencies
Feb 12, 2026
Merged

Feature/upgrade dependencies#23
valdisiljuconoks merged 11 commits intoGeta:masterfrom
CodeArtDK:feature/upgrade-dependencies

Conversation

@AThraen
Copy link
Contributor

@AThraen AThraen commented Jan 22, 2026

I upgraded to .net 8 (as .net 6 is end of life a long time ago). And updated dependencies to Sixlabor to avoid vulnerabilities - also made the dependency open-ended to avoid future issues.

Copilot AI and others added 4 commits January 16, 2026 15:14
Co-authored-by: AThraen <5888420+AThraen@users.noreply.github.com>
Co-authored-by: AThraen <5888420+AThraen@users.noreply.github.com>
…ackages

Upgrade to .NET 8 and fix SixLabors security vulnerabilities
@gemini-code-assist
Copy link

Summary of Changes

Hello @AThraen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the project by upgrading its core framework to .NET 8 and updating several critical dependencies. The primary objectives are to enhance security by patching known vulnerabilities in the SixLabors libraries and to improve maintainability through a more flexible dependency management strategy. These changes bring the project up-to-date with the latest .NET ecosystem, contributing to overall stability and performance.

Highlights

  • .NET 8 Upgrade: The project's target framework has been upgraded from .NET 6 to .NET 8 across all relevant projects, ensuring compatibility with the latest framework features and long-term support.
  • SixLabors Dependency Updates and Security Fixes: Key SixLabors packages (ImageSharp, Fonts, ImageSharp.Drawing) have been updated to their latest versions, specifically addressing several reported CVEs (CVE-2024-32036, CVE-2024-27929, CVE-2024-32035) to enhance security.
  • Open-Ended SixLabors Dependencies: The SixLabors package references have been modified to use open-ended version ranges (e.g., [2.1.3,)), allowing for automatic consumption of future minor and patch updates without requiring manual project file modifications.
  • System.Drawing.Common Integration: The System.Drawing.Common package has been added to the main project, likely to support image manipulation functionalities under the .NET 8 framework.
  • Test Dependency Updates: Various test-related dependencies, including coverlet, FakeItEasy, Microsoft.NET.Test.Sdk, and xunit, have been updated to their latest versions to maintain a robust testing environment.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully upgrades the project to .NET 8 and updates several dependencies, including SixLabors packages to address security vulnerabilities. My review focuses on two main points:

  1. The use of open-ended versioning for the SixLabors dependencies, which can introduce instability. I've recommended pinning them to specific versions.
  2. The addition of the System.Drawing.Common package. This is a critical issue as it breaks cross-platform compatibility, which is a key feature of this library. I've provided guidance on how to remove this dependency by refactoring a color validation method to use ImageSharp's own capabilities.

Overall, the dependency upgrades are a great improvement, but the two issues above should be addressed before merging.

Copilot AI and others added 4 commits January 22, 2026 12:47
Co-authored-by: AThraen <5888420+AThraen@users.noreply.github.com>
…ests

Co-authored-by: AThraen <5888420+AThraen@users.noreply.github.com>
…pendency

Replace System.Drawing.Common with ImageSharp for color validation
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the solution to .NET 8 and refreshes several dependencies (notably SixLabors) as part of addressing reported vulnerabilities, including updating color parsing to rely on ImageSharp for cross-platform support.

Changes:

  • Retargeted projects from net6.0 to net8.0.
  • Updated SixLabors packages (and made their versions open-ended) and refreshed test dependencies.
  • Switched HTML color validation to SixLabors.ImageSharp.Color.TryParse and expanded unit tests for named colors.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/Geta.Optimizely.ContentTypeIcons.Tests/ThumbnailIconControllerTests.cs Adds coverage for named-color parsing and minor test cleanup.
tests/Geta.Optimizely.ContentTypeIcons.Tests/Geta.Optimizely.ContentTypeIcons.Tests.csproj Retargets to net8 and upgrades test/coverage packages.
src/Geta.Optimizely.ContentTypeIcons/Geta.Optimizely.ContentTypeIcons.csproj Retargets to net8; updates SixLabors dependencies to open-ended version ranges.
src/Geta.Optimizely.ContentTypeIcons/Controllers/ContentTypeIconController.cs Replaces regex/System.Drawing-based color validation with ImageSharp parsing.
src/Geta.Optimizely.ContentTypeIcons.EnumGenerator/Geta.Optimizely.ContentTypeIcons.EnumGenerator.csproj Retargets to net8 and upgrades Newtonsoft/Octokit.
sandbox/Alloy/AlloyMvcTemplates.csproj Retargets sandbox to net8.
README.md Updates the platform badge to .NET 8.
CHANGELOG.md Adds a 3.0.0 entry describing the upgrade and dependency changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

AThraen and others added 3 commits February 11, 2026 13:29
…peIcons.csproj

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…zely.ContentTypeIcons.EnumGenerator.csproj

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@valdisiljuconoks valdisiljuconoks merged commit 1f62b83 into Geta:master Feb 12, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants