Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Spanish translation files #91

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

JPBarrio
Copy link

[This is my first entry in Github]
I have translated SettingsGuide into Spanish.
Files can be uploaded once my proposed es_ES folder is accepted.
However, given the multiple translation possibilities for different 3D-world terms from English (i.e. 'ghosting', 'stringing', and so on), I seek collaboration, especially from the original Spanish translators in Cura to try standardizing spanish terminology.

@Ghostkeeper
Copy link
Owner

Ghostkeeper commented Jul 10, 2022

es_ES is indeed accepted. It is the correct name for the directory. The mapping of language codes to user-readable text is here. It's using the ISO 3166-1 language code standard.
I won't accept the PR until it adds something real, if that's the "acceptance" you're looking for. If you need help with Git, feel free to ask!

For the 3D industry terms, Cura's translation guide says to use whatever is most common in the industry. So if you believe that Spanish users tend to use the English words, keep them English, and if they use a Spanish term you'd use that. And it doesn't have to be perfect, so go by intuition I'd say.
I can't really help with the translations themselves. Just be sure to read the translation guidelines: https://github.com/Ghostkeeper/SettingsGuide/blob/master/contributing.md#translating

@JPBarrio
Copy link
Author

JPBarrio commented Jul 10, 2022 via email

@JPBarrio
Copy link
Author

JPBarrio commented Jul 12, 2022 via email

@Ghostkeeper
Copy link
Owner

Hi! Sorry for the delay again.

What you tried to do there is a normal way of working if you are a developer on a Github project. However Github doesn't allow you to directly change my source code. The proper way to contribute to someone else's project is as follows:

  1. You need to fork the project to your own account. This creates a copy of the Settings Guide in your own account. It seems you already did this back in June, because I found this fork in your profile. Because that's your own copy, you'll have access rights to change that one.
  2. You need to download that fork, not my original, to your computer. In Git bash you can do that by entering git clone https://github.com/JPBarrio/SettingsGuide. Previously you might've cloned github.com/Ghostkeeper/SettingsGuide.
  3. Since you already have a pull request (this one) you should make sure you're on the branch of that pull request, that you called patch-1. You can do this by entering git checkout patch-1 in your Git bash.
  4. You then make changes to the source code (copy those files into your newly cloned fork), and make a commit. You already did this correctly, but you'll need to repeat that.
  5. You can then push as you did, using git push. It will succeed this time, and you should see your changes appear in your fork as well as in your pull request.
  6. Normally you'll then need to go to Github.com and create a pull request there. But you already did that, so that is unnecessary now.

I will then be able to review your changes.

For a guide from start to finish, you can use this article. However since you already did a number of those steps, perhaps the steps I outlined above might be easier for you specifically.

Don't be afraid to make mistakes! And to ask for help if you need it.

@Ghostkeeper
Copy link
Owner

It seems that these translations are machine-generated. I'm not allowing machine translations to be contributed here. Please see the translation guidelines.

@JPBarrio
Copy link
Author

JPBarrio commented Aug 16, 2022 via email

@JPBarrio
Copy link
Author

JPBarrio commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants