Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace getHighestGroupAction with ActionGateway method #1666

Draft
wants to merge 2 commits into
base: v26.0.00
Choose a base branch
from

Conversation

yookoala
Copy link
Member

@yookoala yookoala commented Oct 3, 2022

Description

  • Mark getHighestGroupedAction() deprecated.
  • Add ActionGateway::getHighestGrouped as a replacement.
  • Rewrite all getHighestGroupedAction() into
    ActionGateway::getHighestGrouped() calls.

Motivation and Context

  • Replace functions.php function with gateway implementation.

How Has This Been Tested?

  • CI Environment

@yookoala yookoala changed the title Refactor/deprecate get highest group action Replace getHighestGroupAction with ActionGateway method Oct 3, 2022
@yookoala yookoala force-pushed the refactor/deprecate-get-highest-group-action branch 4 times, most recently from 8b00915 to 46e293f Compare October 25, 2022 05:30
@yookoala yookoala force-pushed the refactor/deprecate-get-highest-group-action branch 2 times, most recently from eafe1fc to 6989c78 Compare November 4, 2022 04:36
@yookoala yookoala marked this pull request as draft November 4, 2022 11:42
* Mark getHighestGroupedAction() deprecated.
* Add ActionGateway::getHighestGrouped as a replacement.
* Rewrite all getHighestGroupedAction() into
  ActionGateway::getHighestGrouped() calls.
@yookoala yookoala force-pushed the refactor/deprecate-get-highest-group-action branch from 6989c78 to 0ca8202 Compare October 20, 2023 02:44
@yookoala yookoala changed the base branch from v25.0.00 to v26.0.00 October 20, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant