Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System Admin / Authentication: LDAP Implementation #1691

Draft
wants to merge 2 commits into
base: v25.0.00
Choose a base branch
from

Conversation

powertashton
Copy link
Member

This is an almost complete LDAP implementation using the Aura Auth library that is already used in Gibbon for other forms of authentication.

Still TODO for this PR:

  • Use LDAP domain and bind details from system admin configuration (rather than the current method that uses hardcoded details (that have been redacted))
  • Make it possible to set the LDAP login as the default for login attempts from the normal login form, potentially allowing it to be controlled on a role/individual user basis rather than just a blanket setting across all users.
  • Better exception catching

TODO in future PRs:

  • Enable creation of accounts upon new user LDAP credentials, mapping different fields to each other and probably basing roles off of OUs

Initially made this for use at my old workplace to facilitate easy login to Gibbon, as users were used to only ever needing to use their AD credentials that were linked to most other systems used in the school. Still some configuration that needs working on before merging but wanted to make sure this project doesn't just get lost in my piles of files.

Almost complete LDAP implementation using the Aura Auth LDAP
@rossdotparker
Copy link
Member

This looks very cool! I'll leave it to Sandra to review.

@SKuipers
Copy link
Member

SKuipers commented Nov 1, 2022

Hi @powertashton Looks like this PR is shaping up nicely! It appears to be a nice clean implementation so-far, give a shout with any questions as you get the PR ready to review & merge 😄

@SKuipers
Copy link
Member

SKuipers commented Nov 4, 2022

Hi @powertashton I've added the "in development" label to this PR for now, since it's in draft mode. Feel free to give a shout if you'd like anything reviewed or tested at this point. I think there will definitely be some schools very happy to see this in the core 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants