System: move database, locale and absoluteURL setup into CoreServiceProvider #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yookoala
force-pushed
the
refactor/core-service
branch
from
614a377 to
5bc37ef
Compare
yookoala
changed the title
yookoala
force-pushed
the
refactor/core-service
branch
4 times, most recently
from
8d8e671 to
10966df
Compare
* Move database connection logics from gibbon.php into CoreServiceProvider::boot for clarity.
* replace with the sessionTableHasSetup flag in container.
* Migrate locale object setup from Core::initializeCore to CoreServiceProvider::boot.
* Combine "Globals for backwards compatibility" section.
* Move absoluteURL declaration into CoreServiceProvider.
yookoala
force-pushed
the
refactor/core-service
branch
from
10966df to
1e7168d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?