Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Reversible rng #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] Reversible rng #35

wants to merge 2 commits into from

Conversation

GiggleLiu
Copy link
Owner

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #35 into master will increase coverage by 0.25%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   81.72%   81.98%   +0.25%     
==========================================
  Files          25       26       +1     
  Lines        1029     1049      +20     
==========================================
+ Hits          841      860      +19     
- Misses        188      189       +1     
Impacted Files Coverage Δ
src/stdlib/rng.jl 94.73% <94.73%> (ø)
src/autodiff/checks.jl 90.66% <0.00%> (-0.13%) ⬇️
src/stdlib/mapreduce.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ce20ec...980462c. Read the comment docs.

@cscherrer
Copy link

Getting PPL to work in this way could be challenging, but having a reversible RNG at all will make it now easy to try out some different ideas. We can look more closely at the quality of the RNG and see if we need an alternative if/when we get to that point. Thanks!

@GiggleLiu
Copy link
Owner Author

GiggleLiu commented Sep 26, 2020

Getting PPL to work in this way could be challenging

Always ready to backup your new ideas, at least from the technical side.

We can look more closely at the quality of the RNG

This is why we need experts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reversible RNG?
2 participants