Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] more contents to tutorial #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnnychen94
Copy link
Contributor

I'm still learning NiLang, please kindly point out things that I misunderstood :)

@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #68 (a165d08) into master (268710a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   81.38%   81.38%           
=======================================
  Files          30       30           
  Lines        1402     1402           
=======================================
  Hits         1141     1141           
  Misses        261      261           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 268710a...a165d08. Read the comment docs.

Copy link
Owner

@GiggleLiu GiggleLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks

that `r_axpy!` is an in-place function which modifies the input, and that input `y!` and `out!`
will be modified.

Perhaps surprisingly, you can't write an explicit `return` in `@i`. This is because NiLang's
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn’t this because NiLang returns input arguments automatically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants