add way to deprecate Theme fields and fix 4542f3fb #1180
Conversation
| var = row.args[hasdocstr+1] | ||
| typ = row.args[hasdocstr+2] | ||
| default = length(row.args)-hasdocstr > 2 ? row.args[hasdocstr+3] : :nothing | ||
| depwarnstr = length(row.args)-hasdocstr > 3 ? row.args[hasdocstr+4] : "" |
There was a problem hiding this comment.
So the only thing that determines whether something is deprecated or not is whether it has another docstring line following it? I was thinking that you could explicitly use syntax similar to the @deprecated macro (like explicitly have @deprecated in the first position of the line with the alt text) and then to do some processing to determine whether it's present. It would be nice to be super clear that something is deprecated when looking at the source.
There was a problem hiding this comment.
i've added docs to the top of src/varset.jl to explain the format of the table.
| function $(name)($(parameters_expr)) | ||
| $(depwarns...) | ||
| return $(name)($(parsed_vars...)) | ||
| end |
There was a problem hiding this comment.
I like this approach and this should scale well in the future.
bjarthur
force-pushed
the
bja/fixdepwarn
branch
from
182a18b to
1566b93
Compare
Codecov Report
@@ Coverage Diff @@
## master #1180 +/- ##
==========================================
- Coverage 87.33% 87.33% -0.01%
==========================================
Files 34 34
Lines 4082 4081 -1
==========================================
- Hits 3565 3564 -1
Misses 517 517
Continue to review full report at Codecov.
|
fixes #1175 (comment) by adding another entry to the
varsettable that contains adepwarnstring