Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to implement polar coordinates. I followed @dcjones's suggestion in #610 (although it was for ternary coordinates) to add a new Coord and to make geometries and guides dispatch on the coordinate type. So far this is just a proof of concept, help would be more than welcome!
I introduced two new aesthetics:
rho
(aliases:r
andρ
) andphi
(aliasϕ
), so one doesn't have to specifyCoord.polar
explicitly. I followed ISO 31-11 for the names.I chose to dispatch
element_coordinate_type
on the mapped aesthetics as well as the geometry. Not sure if this is the best way.The biggest issue is with Guides. I don't understand the scale at which they are drawn. Right now the circular grid is too small while the angular grid doesn't even show up.
Eventually, better Stats need to be implemented to compute the grid correctly but I would like to have something basic working.
Here is what I have so far: