Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execute the bottle data tag #446

Merged
merged 5 commits into from
Oct 29, 2024
Merged

execute the bottle data tag #446

merged 5 commits into from
Oct 29, 2024

Conversation

giannif
Copy link
Collaborator

@giannif giannif commented May 10, 2024

No description provided.

Copy link

changeset-bot bot commented May 10, 2024

🦋 Changeset detected

Latest commit: 6bf5f6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@giphy/react-components Minor
@giphy/js-util Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@giannif giannif requested a review from Lizards May 10, 2024 13:04
@giannif giannif requested review from gpadin-cp and removed request for Lizards October 23, 2024 17:06
@@ -4,7 +4,7 @@ let pingbackId = ''
const idLength = 16

/* istanbul ignore next */
const noUUIDRandom = () => {
export const noUUIDRandom = () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, why "no" as a prefix?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gpadin-cp it's not a uuid random id, which requires a somewhat large library, it's just a drop in replacement for a random id

@giannif giannif merged commit 9ff7737 into master Oct 29, 2024
1 check passed
@giannif giannif deleted the bottle-data-tag-fix branch October 29, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants