Skip to content

Assignment 1 Submission #4

Open
Pandas-1 wants to merge 9 commits intoGit-Lecture-2026:feralfrom
Pandas-1:feral
Open

Assignment 1 Submission #4
Pandas-1 wants to merge 9 commits intoGit-Lecture-2026:feralfrom
Pandas-1:feral

Conversation

@Pandas-1
Copy link

review submission

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reformat the text so it's a little easier to read, and also put the password and the commands in different lines and put them in a code block.

@satindra-r
Copy link

  • Make your bash script executable
  • Fix the accuracy logic so it checks accuracy word wise (currently if the sentence is correct but the first letter is missing the accuracy is very low)
  • Try to implement a TUI for the typing part similar to https://github.com/max-niederman/ttyper. you dont have to implement all the features but try to do the typing overlay

@satindra-r
Copy link

also change the target branch to your branch on the repo, currently its pointing to main

@peopleig
Copy link

This is not how you should be naming commits.
Please check commit writing conventions and rename according to them

@Pandas-1 Pandas-1 marked this pull request as draft March 15, 2026 10:20
@Pandas-1 Pandas-1 changed the base branch from main to feral March 15, 2026 10:23
@Pandas-1 Pandas-1 marked this pull request as ready for review March 15, 2026 10:23
fi
play_again=y
while [ "$play_again" == "y" ]; do
quote=$(shuf -n 1 $1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use a relative path here.
If you run the script from outside the parent directory, it should still work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please make the script executable (so the user doesn't have to manually run chmod on it)
  • Right now, I am getting this weird expression in the TUI
    \e[32mA\e[0m\e[32mk\e[0mela said nothing. He was thinking of the time that comes to every
    once I start typing, fix this

Nits

  • It would be better to ask for difficulty once the program is executed, rather than expecting it as input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants