Open
Conversation
Contributor
There was a problem hiding this comment.
Please reformat the text so it's a little easier to read, and also put the password and the commands in different lines and put them in a code block.
|
|
also change the target branch to your branch on the repo, currently its pointing to main |
|
This is not how you should be naming commits. |
…acter for accuracy
| fi | ||
| play_again=y | ||
| while [ "$play_again" == "y" ]; do | ||
| quote=$(shuf -n 1 $1) |
Contributor
There was a problem hiding this comment.
Don't use a relative path here.
If you run the script from outside the parent directory, it should still work.
Contributor
There was a problem hiding this comment.
- Please make the script executable (so the user doesn't have to manually run
chmodon it) - Right now, I am getting this weird expression in the TUI
\e[32mA\e[0m\e[32mk\e[0mela said nothing. He was thinking of the time that comes to every
once I start typing, fix this
Nits
- It would be better to ask for difficulty once the program is executed, rather than expecting it as input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
review submission