Added TvOS, MacOS, iOSX64 support #770
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the build configuration to include support for tvOS by setting deployment targets and adjusting Kotlin opt-ins. Also, updated Gradle and library versions to their latest stable releases as of commit `9b4c5f6`. This change ensures compatibility with new platforms while leveraging the latest features and improvements in dependencies.
Updated the build configuration to include support for macOS by setting appropriate deployment targets. Enhanced platform coverage by adding macOS targets to existing iOS, tvOS, and Kotlin opt-ins. Updated Gradle and library versions to their latest stable releases, ensuring compatibility with new platforms while leveraging recent improvements in dependencies.
Daeda88
approved these changes
Sep 10, 2025
|
Please come back with the iosX64 |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for TvOS, MacOS, and iOSX64 platforms to the Firebase Kotlin SDK by extending the build configurations across all Firebase modules and updating the CI/CD pipeline to test these new platforms.
Key changes:
- Expanded Apple platform support from iOS-only to include TvOS, MacOS, and iOSX64
- Updated build configurations to support the new Apple platforms with appropriate deployment targets
- Added comprehensive test skipping configurations for the new platforms
Reviewed Changes
Copilot reviewed 24 out of 72 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle.properties | Added test skip configuration properties for MacOS and TvOS platforms |
| gradle/libs.versions.toml | Added deployment target versions for TvOS (13.0) and MacOS (10.15) |
| Multiple build.gradle.kts files | Extended Kotlin multiplatform configurations to include new Apple targets and deployment settings |
| GitHub workflow files | Updated CI/CD pipelines to test MacOS and TvOS platforms with specific Xcode version |
| Test utility files | Minor import optimizations and platform detection logic updates |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+88
to
+92
| tvosSimulatorArm64() | ||
|
|
||
| cocoapods { | ||
| ios.deploymentTarget = libs.versions.ios.deploymentTarget.get() | ||
| tvos.deploymentTarget = libs.versions.tvos.deploymentTarget.get() |
There was a problem hiding this comment.
This module adds tvOS targets but does not include macOS targets like other modules. This inconsistency could lead to build issues or confusion about platform support.
Suggested change
| tvosSimulatorArm64() | |
| cocoapods { | |
| ios.deploymentTarget = libs.versions.ios.deploymentTarget.get() | |
| tvos.deploymentTarget = libs.versions.tvos.deploymentTarget.get() | |
| tvosSimulatorArm64() | |
| macosX64() | |
| macosArm64() | |
| macosSimulatorArm64() | |
| cocoapods { | |
| ios.deploymentTarget = libs.versions.ios.deploymentTarget.get() | |
| tvos.deploymentTarget = libs.versions.tvos.deploymentTarget.get() | |
| macos.deploymentTarget = libs.versions.macos.deploymentTarget.get() |
Copilot uses AI. Check for mistakes.
Comment on lines
85
to
87
| iosSimulatorArm64().enableKeychainForTests() | ||
| cocoapods { | ||
| ios.deploymentTarget = libs.versions.ios.deploymentTarget.get() |
There was a problem hiding this comment.
The firebase-auth module does not include tvOS or macOS targets unlike other Firebase modules, creating inconsistent platform support across the SDK.
Suggested change
| iosSimulatorArm64().enableKeychainForTests() | |
| cocoapods { | |
| ios.deploymentTarget = libs.versions.ios.deploymentTarget.get() | |
| iosSimulatorArm64().enableKeychainForTests() | |
| macosX64() | |
| macosArm64() | |
| macosSimulatorArm64() | |
| tvosX64() | |
| tvosArm64() | |
| tvosSimulatorArm64() | |
| cocoapods { | |
| ios.deploymentTarget = libs.versions.ios.deploymentTarget.get() | |
| macos.deploymentTarget = libs.versions.macos.deploymentTarget.get() | |
| tvos.deploymentTarget = libs.versions.tvos.deploymentTarget.get() |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is taken from #729
Thank you for your contributions @sajidalidev
I have rebased and re-added iosX64.