Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove git2 from cargo-smart-release #952

Closed
wants to merge 1 commit into from
Closed

Conversation

Byron
Copy link
Member

@Byron Byron commented Jul 29, 2023

Note that this also removes the vendored-openssl feature as it doesn't exist in crates-index
anymore.

Also use the latest version of crates-index

Depends on frewsxcv/rust-crates-index#136 to be made.

@Byron Byron force-pushed the smart-release-without-git2 branch from 905fdde to 9799f0c Compare July 29, 2023 15:35
…`crates-index`

Note that this also removes the `vendored-openssl` feature as it doesn't exist in `crates-index`
anymore.
@Byron Byron force-pushed the smart-release-without-git2 branch from 9799f0c to c56b52f Compare July 29, 2023 19:32
@niklaswimmer
Copy link
Contributor

Just as a heads up in case you did not notice, but cargo-smart-release does currently not compile on main (because the branch the Git dependency points to no longer exists).

@Byron
Copy link
Member Author

Byron commented Jul 29, 2023

That was quick, and thanks for the heads-up!

I hope to be able to merge this PR once CI is green, I am basically waiting for it :D .

@niklaswimmer
Copy link
Contributor

Jeah I just happen to work on stuff right now so I noticed it failing 😅

@Byron
Copy link
Member Author

Byron commented Jul 29, 2023

Should be good now, this PR was merged back.

@Byron Byron closed this Jul 29, 2023
@Byron Byron deleted the smart-release-without-git2 branch July 29, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants