-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: network modal showing while the page is loading #4711
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
a39b561
fix: network modal showing while the page is loading
HrithikSampson d305aaa
keep the sanctions modal until the page has redirected to all pages
HrithikSampson 7d78930
fix: run linter
HrithikSampson db131da
Merge branch 'develop' of github.com:Giveth/giveth-dapps-v2 into fix_…
HrithikSampson 69eaf28
fix: multiple donation modal shown together
HrithikSampson ff6405e
add OFAC Sanction Modal
HrithikSampson d502cec
fix; Donate Modals glitching effect
HrithikSampson edaa8a5
chore: fix build errors
HrithikSampson 34829fe
fix: OFAC Sanction Modal Check
HrithikSampson 3c6e005
fix: coderabbitai suggestions
HrithikSampson 76c0908
Merge branch 'develop' of github.com:Giveth/giveth-dapps-v2 into fix_…
HrithikSampson f1fe063
manually revet coderabbit suggestions as it is causing glitching again
HrithikSampson a842504
run linter
HrithikSampson e803c77
fix: timeout to add check of the modals later
HrithikSampson 73c22b4
Merge branch 'develop' of github.com:Giveth/giveth-dapps-v2 into fix_…
HrithikSampson d0ba7ce
Merge branch 'develop' of github.com:Giveth/giveth-dapps-v2 into fix_…
HrithikSampson 969417a
run linter:
HrithikSampson 593d3d4
fix: for non-endaoment project modal
HrithikSampson c7854e2
run linter
HrithikSampson 3b90b81
Merge branch 'develop' of github.com:Giveth/giveth-dapps-v2 into fix_…
HrithikSampson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle potential errors from
isWalletSanctioned
API callIn the
validateSanctions
function, the asynchronous call toisWalletSanctioned(address)
may fail due to network errors or other issues. To ensure the application remains stable, consider wrapping the API call in a try-catch block to handle any potential exceptions.Apply this diff to enhance error handling:
Committable suggestion