Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict dev environment to python<3.12 #437

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

atedstone
Copy link
Member

Resolves #428 .

@atedstone atedstone requested a review from rhugonnet January 18, 2024 07:50
@rhugonnet
Copy link
Member

@atedstone You also need to add the restriction in environment.yml, otherwise a specific test in CI fails! (the two files always need to be consistent for the main dependencies)

@atedstone
Copy link
Member Author

@rhugonnet so it seems. I'll add to environment.yml as well but this does seem like a 'sledgehammer to crack a nut' approach!

@adehecq adehecq merged commit 920487d into GlacioHack:main Jan 18, 2024
13 checks passed
@atedstone atedstone deleted the fix_dev_mypy branch January 18, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

pre-commit installation fails due to distutils import
3 participants